[jira] [Updated] (AVRO-1343) Python: validate too permissive on records with extra fields

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (AVRO-1343) Python: validate too permissive on records with extra fields

Krishnan Sundaram (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ismaël Mejía updated AVRO-1343:
-------------------------------
    Fix Version/s:     (was: 1.10.0)

> Python: validate too permissive on records with extra fields
> ------------------------------------------------------------
>
>                 Key: AVRO-1343
>                 URL: https://issues.apache.org/jira/browse/AVRO-1343
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: python
>            Reporter: Jeremy Kahn
>            Assignee: Jeremy Kahn
>            Priority: Major
>         Attachments: AVRO-1343-tests.patch, AVRO-1343-validate.patch
>
>
> Python's validator silently accepts (generic) records with extra fields and considers them valid.
> For example, {{io.validate}} silently considers that the schema:
> {noformat}{"type": "record",
>  "name": "Test",
>  "fields": [{"name": "f", "type": "long"}]}
> {noformat}
> should accept records like:
> {noformat}{'f': 5, 'extra_field': "abc"}{noformat}
> but this is problematic.
> This is *especially* problematic for encoding unions, because internally the Python serializer uses {{validate}} to find the appropriate schema with which to encode a given object.
> In the current implementation, union schema selection is the *last* schema that {{validate(schema, obj)}} returns {{True}} for.  If {{validate}} isn't picky, this encoding will frequently guess wrong.
> I will attach two patches: one to the tests and one to the {{validate}} function.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)