[jira] Created: (AVRO-502) Memory leak from parsing JSON schema.

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
Memory leak from parsing JSON schema.
-------------------------------------

                 Key: AVRO-502
                 URL: https://issues.apache.org/jira/browse/AVRO-502
             Project: Avro
          Issue Type: Bug
          Components: c
    Affects Versions: 1.3.2
         Environment: Linux 2.6.28 Gentoo
            Reporter: Robert G. Jakabosky


the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.

I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment: avro_leak.log

valgrind memcheck output when running benchmark from project:
http://github.com/Neopallium/serialization-benchmarks

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak.log
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment:     (was: avro_leak.log)

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_debug.log
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment: avro_leak.log

valgrind memcheck output with debugging info turned on.

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_debug.log
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment:     (was: avro_leak.log)

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_debug.log
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment: avro_leak_debug.log

sorry, this is the correct one with debug info.

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_debug.log
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment: avro_leak_with_debug.log

Sorry again for the noise.  This should be the correct one now.

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_debug.log, avro_leak_with_debug.log
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment:     (was: avro_leak_debug.log)

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment: test_schema_leaks.c

program with embedded json schema for testing this bug.

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, test_schema_leaks.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment: schema_leaks.patch

patch to fix two refcounting leaks.  I think there might be more leaks when using maps and unions.

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, schema_leaks.patch, test_schema_leaks.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment: test_schema_leaks_with_map_and_union.c

new test program to show leaks with map & unions.

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, schema_leaks.patch, schema_leaks2.patch, test_schema_leaks.c, test_schema_leaks_with_map_and_union.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment: schema_leaks2.patch

new patch fixes all leaks.

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, schema_leaks.patch, schema_leaks2.patch, test_schema_leaks.c, test_schema_leaks_with_map_and_union.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment:     (was: schema_leaks.patch)

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, schema_leaks2.patch, test_schema_leaks.c, test_schema_leaks_with_map_and_union.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment:     (was: test_schema_leaks.c)

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, schema_leaks2.patch, test_schema_leaks_with_map_and_union.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment:     (was: test_schema_leaks_with_map_and_union.c)

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, schema_leaks2.patch, test_schema_leaks_with_map_and_union.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert G. Jakabosky updated AVRO-502:
-------------------------------------

    Attachment: test_schema_leaks_with_map_and_union.c

new test program to show leaks with map & unions.   re-upload with ASF grant.

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, schema_leaks2.patch, test_schema_leaks_with_map_and_union.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Massie resolved AVRO-502.
------------------------------

    Resolution: Fixed

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, schema_leaks2.patch, test_schema_leaks_with_map_and_union.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

    [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853256#action_12853256 ]

Matt Massie commented on AVRO-502:
----------------------------------

Robert-

Thanks for the clean patch and well-designed test case.  I've just committed your patch to trunk.

Can you try to assign this JIRA to yourself so that you get the credit you deserve for the work?  If you are unable to assign it, I will find a JIRA admin who can.

Should we expect to see Avro bindings for Lua anytime soon?   :)

Bruce Mitchener is doing some performance work now on Avro-C that should dramatic improve performance.  Hopefully that will be seen in the results of your serialization benchmark.

 

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, schema_leaks2.patch, test_schema_leaks_with_map_and_union.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (AVRO-502) Memory leak from parsing JSON schema.

ASF subversion and git services (Jira)
In reply to this post by ASF subversion and git services (Jira)

     [ https://issues.apache.org/jira/browse/AVRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Carey reassigned AVRO-502:
--------------------------------

    Assignee: Robert G. Jakabosky

> Memory leak from parsing JSON schema.
> -------------------------------------
>
>                 Key: AVRO-502
>                 URL: https://issues.apache.org/jira/browse/AVRO-502
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.2
>         Environment: Linux 2.6.28 Gentoo
>            Reporter: Robert G. Jakabosky
>            Assignee: Robert G. Jakabosky
>         Attachments: avro_leak_with_debug.log, schema_leaks2.patch, test_schema_leaks_with_map_and_union.c
>
>
> the avro_schema_from_json() function seems to leak memory, even after the reference to the schema is released.
> I will attache output from valgrind.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.