[jira] [Commented] (AVRO-3150) Checkstyle requires LF line endings: add .gitattributes hint

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (AVRO-3150) Checkstyle requires LF line endings: add .gitattributes hint

Dave Cole (Jira)

    [ https://issues.apache.org/jira/browse/AVRO-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350568#comment-17350568 ]

Ryan commented on AVRO-3150:
----------------------------

https://github.com/apache/avro/pull/1236

> Checkstyle requires LF line endings: add .gitattributes hint
> ------------------------------------------------------------
>
>                 Key: AVRO-3150
>                 URL: https://issues.apache.org/jira/browse/AVRO-3150
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.10.2
>            Reporter: Ryan
>            Priority: Major
>
> Running the Java unit tests on a Windows machine with the commonly configured git line ending configuration:
> {quote}{{git config --global core.autocrlf true}}
> {quote}
> Results in test failure of:
> {quote}{{NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.}}
> {quote}
> This is due to a checkstyle rule.   If the unit tests require LF line endings then it would be helpful to add a .gitattributes file to automatically ensure the correct line endings are used on git clone.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)