[jira] [Commented] (AVRO-3118) Namespace with empty string is not treated as null in Python API

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (AVRO-3118) Namespace with empty string is not treated as null in Python API

Dave Cole (Jira)

    [ https://issues.apache.org/jira/browse/AVRO-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347279#comment-17347279 ]

Scott commented on AVRO-3118:

In that case it sounds like the specification should be changed so that instead of this:

References to previously defined names are as in the latter two cases above: if they contain a dot they are a fullname, if they do not contain a dot, the namespace is the namespace of the enclosing definition.

It says this:

References to previously defined names are always treated as fullnames. If the reference does not have a dot then it is considered to have a null namespace.

If so I can open a new ticket and resolve that.

> Namespace with empty string is not treated as null in Python API
> ----------------------------------------------------------------
>                 Key: AVRO-3118
>                 URL: https://issues.apache.org/jira/browse/AVRO-3118
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: python
>    Affects Versions: 1.10.2
>            Reporter: Frank Mieves
>            Assignee: Michael A. Smith
>            Priority: Blocker
> Hi,
> based on [the AVRO documentation|https://avro.apache.org/docs/current/spec.html#names] an empty string may also be used as a namespace to indicate the null namespace.
> The Python package doesn't do that. Following example will fail when parsing:
> {code:python}
> import avro.schema
> schema_str="""
> {"type": "record", "name": "my_schema", "namespace": "my_ns",
>  "fields": [{"name": "field_a", "type": {"type": "record", "name": "row", "namespace": "",
>  "fields": [{"name": "subfield", "type": "string"}]}},
>  {"name": "field_b", "type": "row"}
>  ]}
> """
> schema = avro.schema.parse(schema_str)
> {code}
> Raised exception is "SchemaParseException: Type property "row" not a valid Avro schema: Could not make an Avro Schema object from row."
> If I set the namespace in the in the subfield to null it's working.
> Problem for me is, that I can't change the schema definition. The schema is in the Kafka schema repository. The Kafka AVRO consumer receives this from the schema registry server with an empty string.
> I could fix this by adding a check in the parser source schema.py:
> {code:python}
> ...
> return writer.type == self.type and (self.type == 'request' or self.check_props(writer, ['fullname']))
> def __init__(self, name, namespace, fields, names=None, schema_type='record', doc=None, other_props=None):
>     # Fixing empty namespace
>     if namespace == '':
>         namespace = None
>     # Ensure valid ctor args
>     if fields is None:
>         ...
> {code}

This message was sent by Atlassian Jira