[jira] [Commented] (AVRO-1957) TimeConversions do not implement getRecommendedSchema()

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (AVRO-1957) TimeConversions do not implement getRecommendedSchema()

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/AVRO-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116500#comment-16116500 ]

Nandor Kollar commented on AVRO-1957:
-------------------------------------

Looks good to me, {{mvn clean verify}} passed.

> TimeConversions do not implement getRecommendedSchema()
> -------------------------------------------------------
>
>                 Key: AVRO-1957
>                 URL: https://issues.apache.org/jira/browse/AVRO-1957
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.8.1
>            Reporter: Sean Timm
>            Assignee: Sean Timm
>             Fix For: 1.8.3
>
>
> org.apache.avro.data.TimeConversions.TimestampConversion and other date and time conversions do not implement getRecommendedSchema(). When trying to dynamically generate an Avro schema from a pojo that contains a DateTime object using ReflectData, I get an unsupported operation exception.
> I think the implementation should be as simple as
> {code}
> @Override
> public Schema getRecommendedSchema() {
>       return LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG));
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Loading...