[jira] [Commented] (AVRO-1658) Add avroDoc on reflect

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (AVRO-1658) Add avroDoc on reflect

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/AVRO-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123468#comment-16123468 ]

Nandor Kollar commented on AVRO-1658:
-------------------------------------

I didn't see any test failure after merging Evan's PR, all unit test passed. I just had to resolve a merge conflict in the test class, the patch looks good to me.

> Add avroDoc on reflect
> ----------------------
>
>                 Key: AVRO-1658
>                 URL: https://issues.apache.org/jira/browse/AVRO-1658
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Zhaonan Sun
>            Assignee: Zhaonan Sun
>              Labels: reflection
>         Attachments: 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch, 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch, 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch
>
>
> Looks like @AvroMeta can't add reserved fields, like @AvroMeta("doc", "some doc") will have exceptions.
> I would be greate if we have a @AvroDoc("some documentations") in org.apache.avro.reflect



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Loading...