[jira] [Commented] (AVRO-1574) Suboptimal arraylist creation

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (AVRO-1574) Suboptimal arraylist creation

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/AVRO-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048038#comment-16048038 ]

Nandor Kollar commented on AVRO-1574:
-------------------------------------

LGTM

> Suboptimal arraylist creation
> -----------------------------
>
>                 Key: AVRO-1574
>                 URL: https://issues.apache.org/jira/browse/AVRO-1574
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Zoltan Farkas
>            Priority: Trivial
>         Attachments: AVRO-1574.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> in Schema.java:
> 1231         LockableArrayList<String> symbols = new LockableArrayList<String>();
>  
> 1232         for (JsonNode n : symbolsNode)
>  
> 1233           symbols.add(n.getTextValue());
> should be changed to:
> 1231         LockableArrayList<String> symbols = new LockableArrayList<String>(symbolsNode.size());
>  
> 1232         for (JsonNode n : symbolsNode)
>  
> 1233           symbols.add(n.getTextValue());
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)