[GitHub] [avro] slominskir opened a new pull request #1236: AVRO-3150: .gitattributes indicate LF line endings

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[GitHub] [avro] slominskir opened a new pull request #1236: AVRO-3150: .gitattributes indicate LF line endings


slominskir opened a new pull request #1236:
URL: https://github.com/apache/avro/pull/1236

   Java Unit Tests require LF line endings, even on Windows else fail with NewlineAtEndOfFile checkstyle error
   Make sure you have checked _all_ steps below.
   ### Jira
   - [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-3150
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   To test just clone project on a Windows machine where git has global autocrlf configured.
   ### Commits
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   ### Documentation
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]