[GitHub] avro pull request #239: AVRO-2063. C: VERSION, SOVERSION not set correctly f...

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] avro pull request #239: AVRO-2063. C: VERSION, SOVERSION not set correctly f...

gszadovszky
GitHub user edmonds opened a pull request:

    https://github.com/apache/avro/pull/239

    AVRO-2063. C: VERSION, SOVERSION not set correctly for shared library

    Prior to this commit the `VERSION` and `SOVERSION` properties were not being set correctly for the Avro C shared library. Previously, `VERSION` was unset, and `SOVERSION` was set to the full dotted version string (e.g. "23.0.0"), which resulted in a `SONAME` of "libavro.so.23.0.0", which is incorrect.
   
    This commit sets `SOVERSION` to the library's "current" version number (obtained by invoking `version.sh libcurrent`), and sets `VERSION` to the full dotted version string.
   
    This should result in a proper `libavro.so` → `libavro.so.23` → `libavro.so.23.0.0` symlink chain with a `SONAME` of "libavro.so.23".
   
    See Sune Vuorela's article on "CMake and library properties": http://pusling.com/blog/?p=352.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/edmonds/avro edmonds/AVRO-2063

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #239
   
----
commit 5e852265ea7197efe809a8c37ec6a0c34811d3ba
Author: Robert Edmonds <[hidden email]>
Date:   2017-08-07T23:02:35Z

    AVRO-2063. C: VERSION, SOVERSION not set correctly for shared library
   
    Prior to this commit the VERSION and SOVERSION properties were not being
    set correctly for the Avro C shared library. Previously, VERSION was
    unset, and SOVERSION was set to the full dotted version string (e.g.
    "23.0.0"), which resulted in a SONAME of "libavro.so.23.0.0", which is
    incorrect.
   
    This commit sets SOVERSION to the library's "current" version number
    (obtained by invoking "version.sh libcurrent"), and sets VERSION to the
    full dotted version string.
   
    This should result in a proper libavro.so → libavro.so.23 →
    libavro.so.23.0.0 symlink chain with a SONAME of "libavro.so.23".
   
    See Sune Vuorela's article on "CMake and library properties":
    http://pusling.com/blog/?p=352.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...