[GitHub] avro pull request #231: Ruby 2.4 deprecation fixes

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
Report Content as Inappropriate

[GitHub] avro pull request #231: Ruby 2.4 deprecation fixes

GitHub user tjwp opened a pull request:


    Ruby 2.4 deprecation fixes

    Remove references to `Fixnum` and `Bignum` as suggested by @sldblog [here](https://github.com/apache/avro/pull/191#pullrequestreview-23737308). Ruby 2.4 unified these in a single `Integer` class.
    Also, replace `File.exists?` with `File.exist`.
    Changes tested with:
      - 1.9.3-p551
      - 2.0.0-p648
      - 2.1.10
      - 2.2.7
      - 2.3.4
      - 2.4.1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/salsify/avro ruby-2.4-deprecations

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #231
commit f92357475b67359dde74df8af9a8c0e1c5d5204d
Author: Tim Perkins <[hidden email]>
Date:   2017-06-12T18:26:05Z

    Ruby 2.4 deprecation fixes


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.