Quantcast

[GitHub] avro pull request #191: AVRO-1996: compatibility with Ruby 2.4

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] avro pull request #191: AVRO-1996: compatibility with Ruby 2.4

erikvanoosten
GitHub user tjwp opened a pull request:

    https://github.com/apache/avro/pull/191

    AVRO-1996: compatibility with Ruby 2.4

    In Ruby 2.4, Fixnum and Bignum classes are deprecated and unified in the Integer class.
   
    In earlier Ruby versions, Integer was an abstract parent of the Fixnum and Bignum classes, therefore conditions of the form `value.is_a?(Fixnum) || value.is_a?(Bignum)` can be replaced by `value.is_a?(Integer)` across versions.
   
    Fixnum and Bignum still exist as aliases for Integer in Ruby 2.4
   
    Tested against ruby versions:
      - 1.9.3-p551
      - 2.0.0-p648
      - 2.1.10
      - 2.2.6
      - 2.3.3
      - 2.4.0

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/salsify/avro ruby-2.4-compatibility

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #191
   
----
commit 34b25f663c7acf9fb74d73d3e2069081362667a4
Author: Tim Perkins <[hidden email]>
Date:   2017-01-30T20:48:58Z

    AVRO-1996: compatibility with Ruby 2.4

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] avro pull request #191: AVRO-1996: compatibility with Ruby 2.4

erikvanoosten
Github user asfgit closed the pull request at:

    https://github.com/apache/avro/pull/191


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...